allow configuration of PingTimeout/ReadIdleTimeout#512
allow configuration of PingTimeout/ReadIdleTimeout#512dongjiang1989 wants to merge 2 commits intoprometheus:mainfrom
Conversation
Signed-off-by: dongjiang1989 <dongjiang1989@126.com>
Signed-off-by: dongjiang1989 <dongjiang1989@126.com>
|
What is your usecase? I feel like PingTimeout might be tricky, how well is that supported by http2 vendors? |
When I use common to establish an http2 connection to nginx, the connection is found to be use of closed network connection. Ref. kubernetes/kubernetes#95981 Using PingTimeout, the client will find that the connection is complete and respond, and actively close the connection. |
|
Where do you plan to configure this? Are you using common in your own software or is it for prometheus? |
It is used for prometheus and prometheus-adapter frist. |
2 participants
Allow configuration of PingTimeout/ReadIdleTimeout at the HTTP2.
PingTimeoutdefaults to15s, which is relaxed enough in most network conditions.ReadIdleTimeoutdefaults to1m, which I think is not going to cause performance issues.Ref. kubernetes/kubernetes#95981